AdityaTeltia opened a new pull request, #15161:
URL: https://github.com/apache/lucene/pull/15161
Closes #15038
- Made BitSet a sealed abstract class permitting only FixedBitSet and
SparseFixedBitSet.
- Declared SparseFixedBitSet as final to comply with sealed hierarchy.
- Removed test-only subclass JavaUtilBitSet which was no longer permitted.
- Refactored BaseBitSetTestCase to introduce an abstract
fromJavaUtilBitSet(...) factory.
- Implemented fromJavaUtilBitSet(...) in TestFixedBitSet and
TestSparseFixedBitSet to build the
correct BitSet implementation from a java.util.BitSet for testing.
This ensures that only Lucene’s optimized implementations of BitSet are
allowed, preventing
accidental performance regressions from custom subclasses, while keeping
existing tests valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]