jainankitk commented on code in PR #15149:
URL: https://github.com/apache/lucene/pull/15149#discussion_r2323781139
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90NormsProducer.java:
##########
@@ -394,6 +394,14 @@ public long longValue() throws IOException {
public long longValue() throws IOException {
return slice.readByte(doc);
}
+
+ @Override
+ public void longValues(int size, int[] docs, long[] values, long
defaultValue)
+ throws IOException {
+ // Delegate to help performance: when the super call inlines,
calls to
+ // #advanceExact/#longValue become monomorphic.
Review Comment:
I will probably call this _identity/dummy wrapper to help performance_. Also
I am assuming that `super.longValues` will always inline, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
