RamakrishnaChilaka commented on PR #15140:
URL: https://github.com/apache/lucene/pull/15140#issuecomment-3243796607
I have implemented the following changes:
* Refactored `LongHeap` to include static helper methods `upHeap()` and
`downHeap()` that accept arity as a parameter
* Added a new `TernaryLongHeap` class with `arity = 3`.
* Updated `TopScoreDocCollector` to use `TernaryLongHeap` instead of
`LongHeap`.
* Left `LongHeap` as binary-arity (`arity = 2`) unchanged, i.e. its
`upHeap`/`downHeap` remain separate to avoid any regressions.
I re-ran benchmarks on c8g.8xlarge (graviton) instance.
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
BrowseMonthTaxoFacets 3.21 (6.7%) 3.14
(2.0%) -2.3% ( -10% - 6%) 0.133
BrowseDateTaxoFacets 3.94 (11.0%) 3.88
(8.0%) -1.6% ( -18% - 19%) 0.587
BrowseDayOfYearTaxoFacets 3.95 (10.6%) 3.88
(7.7%) -1.6% ( -17% - 18%) 0.581
AndHighLow 1644.06 (3.0%) 1618.80
(1.9%) -1.5% ( -6% - 3%) 0.053
HighTermDayOfYearSort 113.88 (3.4%) 112.21
(2.8%) -1.5% ( -7% - 4%) 0.137
BrowseDateSSDVFacets 1.06 (9.3%) 1.05
(9.7%) -1.1% ( -18% - 19%) 0.719
BrowseRandomLabelTaxoFacets 2.95 (7.9%) 2.92
(5.7%) -1.0% ( -13% - 13%) 0.633
TermDTSort 140.32 (3.1%) 138.94
(3.6%) -1.0% ( -7% - 5%) 0.357
HighTermTitleBDVSort 34.29 (2.3%) 33.96
(2.5%) -0.9% ( -5% - 3%) 0.212
range 4030.14 (4.9%) 4004.47
(3.4%) -0.6% ( -8% - 8%) 0.633
MedTermDayTaxoFacets 58.42 (1.6%) 58.08
(2.1%) -0.6% ( -4% - 3%) 0.312
AndHighMedDayTaxoFacets 62.61 (0.9%) 62.30
(1.0%) -0.5% ( -2% - 1%) 0.101
HighTermTitleSort 86.93 (2.0%) 86.73
(2.7%) -0.2% ( -4% - 4%) 0.758
HighSloppyPhrase 32.36 (3.1%) 32.34
(3.1%) -0.1% ( -6% - 6%) 0.932
BrowseRandomLabelSSDVFacets 4.08 (10.8%) 4.08
(11.0%) 0.0% ( -19% - 24%) 0.999
BrowseDayOfYearSSDVFacets 5.26 (7.0%) 5.27
(12.0%) 0.2% ( -17% - 20%) 0.954
AndHighHighDayTaxoFacets 26.54 (0.9%) 26.59
(1.2%) 0.2% ( -1% - 2%) 0.571
PKLookup 245.99 (1.2%) 246.64
(2.4%) 0.3% ( -3% - 3%) 0.657
MedSloppyPhrase 76.81 (3.0%) 77.12
(3.6%) 0.4% ( -6% - 7%) 0.695
OrHighMedDayTaxoFacets 12.97 (4.0%) 13.02
(4.5%) 0.5% ( -7% - 9%) 0.739
Respell 38.33 (2.0%) 38.55
(1.9%) 0.6% ( -3% - 4%) 0.329
HighIntervalsOrdered 10.47 (9.0%) 10.53
(9.7%) 0.6% ( -16% - 21%) 0.838
HighSpanNear 5.59 (3.6%) 5.63
(3.2%) 0.8% ( -5% - 7%) 0.468
HighTermMonthSort 252.82 (3.9%) 254.86
(5.5%) 0.8% ( -8% - 10%) 0.592
LowPhrase 77.26 (1.8%) 78.11
(1.3%) 1.1% ( -2% - 4%) 0.028
LowSloppyPhrase 131.76 (2.5%) 133.56
(2.3%) 1.4% ( -3% - 6%) 0.075
MedIntervalsOrdered 53.50 (4.6%) 54.25
(4.9%) 1.4% ( -7% - 11%) 0.349
Fuzzy1 93.04 (1.1%) 94.40
(1.4%) 1.5% ( -1% - 4%) 0.000
BrowseMonthSSDVFacets 5.53 (13.0%) 5.62
(15.0%) 1.5% ( -23% - 33%) 0.736
Fuzzy2 79.01 (1.3%) 80.34
(1.4%) 1.7% ( 0% - 4%) 0.000
HighPhrase 52.31 (1.7%) 53.19
(1.5%) 1.7% ( -1% - 4%) 0.001
OrNotHighHigh 178.27 (6.7%) 181.77
(6.4%) 2.0% ( -10% - 16%) 0.344
MedPhrase 93.34 (1.7%) 95.35
(1.0%) 2.2% ( 0% - 4%) 0.000
OrHighNotHigh 161.33 (7.8%) 165.05
(7.7%) 2.3% ( -12% - 19%) 0.345
LowIntervalsOrdered 113.89 (6.3%) 116.73
(7.0%) 2.5% ( -10% - 16%) 0.234
Prefix3 446.66 (1.1%) 460.53
(2.2%) 3.1% ( 0% - 6%) 0.000
IntSet 797.35 (3.6%) 829.10
(5.9%) 4.0% ( -5% - 14%) 0.010
LowSpanNear 292.44 (3.4%) 304.43
(2.7%) 4.1% ( -1% - 10%) 0.000
AndHighHigh 171.85 (12.6%) 179.11
(12.5%) 4.2% ( -18% - 33%) 0.288
IntNRQ 540.65 (3.0%) 564.98
(1.8%) 4.5% ( 0% - 9%) 0.000
OrHighHigh 145.55 (10.5%) 152.50
(12.0%) 4.8% ( -16% - 30%) 0.180
Wildcard 691.41 (2.7%) 728.49
(2.9%) 5.4% ( 0% - 11%) 0.000
OrNotHighLow 1070.20 (1.7%) 1127.88
(2.8%) 5.4% ( 0% - 10%) 0.000
MedSpanNear 223.45 (2.3%) 235.74
(1.8%) 5.5% ( 1% - 9%) 0.000
AndHighMed 460.42 (4.5%) 486.06
(4.6%) 5.6% ( -3% - 15%) 0.000
OrNotHighMed 381.97 (3.9%) 404.81
(4.5%) 6.0% ( -2% - 14%) 0.000
OrHighLow 275.73 (10.0%) 298.67
(11.7%) 8.3% ( -12% - 33%) 0.015
HighTerm 270.46 (13.9%) 294.96
(16.8%) 9.1% ( -18% - 46%) 0.063
OrHighNotMed 387.26 (6.6%) 425.74
(8.6%) 9.9% ( -4% - 26%) 0.000
OrHighNotLow 367.92 (11.3%) 406.06
(15.2%) 10.4% ( -14% - 41%) 0.014
OrHighMed 384.93 (4.2%) 427.50
(5.5%) 11.1% ( 1% - 21%) 0.000
MedTerm 533.01 (7.4%) 611.25
(9.9%) 14.7% ( -2% - 34%) 0.000
LowTerm 779.05 (7.2%) 917.16
(9.3%) 17.7% ( 1% - 36%) 0.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
