thecoop commented on code in PR #15134:
URL: https://github.com/apache/lucene/pull/15134#discussion_r2306702052
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SortingStrategy.java:
##########
@@ -107,11 +104,7 @@ public String next() throws IOException {
@Override
public void close() throws IOException {
reader.close();
- if (success) {
- tempDir.deleteFile(sortedFile);
- } else {
- IOUtils.deleteFilesIgnoringExceptions(tempDir, sortedFile);
- }
+ tempDir.deleteFile(sortedFile);
Review Comment:
Exceptions thrown by this should be handled by the method calling this
`close()` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
