RamakrishnaChilaka commented on PR #15122: URL: https://github.com/apache/lucene/pull/15122#issuecomment-3220343731
Got it, Thanks for checking the PR @dweiss. I agree that keeping the code simple is important. I observed improvements specifically in the microbenchmarks, but I haven’t checked macrobenchmarks yet. I can run a macrobenchmark comparison (using luceneutil) to see if the unrolled version provides any measurable end-to-end benefit before proceeding further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
