uschindler commented on PR #15089: URL: https://github.com/apache/lucene/pull/15089#issuecomment-3214968845
I have an idea how to solve the whole thing and remove all spezializations from IndexInput/DataInput. IMHO the GroupVInt code should solely be in GroupVIntUtil! Basically, the problem of the optimization is that it needs absolute access because it needs t go forward backwards during decoding. So Actually it need RandomAccessInput. Let's imply rewrite the code that it does instanceof RandomAccessInput (it shoudl not create a new one!!!!!) and if thats the case, just user the readInt(long pos) methods. If an IndexInput does not impelment RandomAcccess it would use the current code. Basically this would automatically improve MMap and ByteBuffers dircetory (the only important IndexInputs). NIOFSDir's IndexInput does not implement RandomAccessInput, so it won't get an optimization, but that ok - i think? @rmuir @jpountz what do you think. I can give it a try! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
