ManasviGoyal commented on PR #15090: URL: https://github.com/apache/lucene/pull/15090#issuecomment-3207988451
> All lucene formats are named based. Meaning, no arguments can actually be applied to the reader. > > How does this actually work in practice? > > I would expect a new format class is required for any different flat format that is used for HNSW because of names format loader Yes this is correct. Each distinct flat format still needs its own named `FlatVectorsFormat` This PR just lets `Lucene99HnswVectorsFormat` delegate to whichever named flat format is provided at write time, so we don’t need a new HNSW outer format class for each variation. HNSW stays the same and delegates to the named flat format chosen at write time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
