uschindler commented on PR #15089: URL: https://github.com/apache/lucene/pull/15089#issuecomment-3198390866
Thanks @rmuir for benchmarking in parallel to my development. I will cleanup the PR a bit. The instability of the original code in the MMap case is caused by the broken inlining and/or escape analysis of the captured lambda. The main problem of the code is that the lambda is captured (it refers to a local variable in the implementation) and this breaks performance if escape analysis does not work as it should. This also explains why @mikemccand has seen high GC activity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
