msfroh commented on code in PR #15050:
URL: https://github.com/apache/lucene/pull/15050#discussion_r2277714025
##########
lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/PointRangeQueryBuilder.java:
##########
@@ -75,32 +76,33 @@ public Query getQuery(Element e) throws ParserException {
String field = DOMUtils.getAttributeWithInheritanceOrFail(e, "fieldName");
final String lowerTerm = DOMUtils.getAttribute(e, "lowerTerm", null);
final String upperTerm = DOMUtils.getAttribute(e, "upperTerm", null);
+ String type = DOMUtils.getAttribute(e, "type",
"int").toLowerCase(Locale.getDefault());
Review Comment:
Note that this is locale-specific, so for example, if the type is `INT` on a
Turkish machine, it will be lowercased to `ınt` (the dotless i).
This should be lower-cased using `Locale.ROOT` to make it locale-insensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
