shubhamsrkdev commented on issue #14959: URL: https://github.com/apache/lucene/issues/14959#issuecomment-3179680263
@jpountz I was looking at this, it makes sense but I had a question about the last part : > I'm also wondering if we need to keep the current approach that is based on a ratio, or if only supporting a fixed threshold would be good enough. I understand that at this point the CFS ratio is set in merge policies (`setNoCFSRatio`), if we intend to keep the two things simultaneously, wouldn't it be too confusing? That is, CFS ratio is set in merge polices but the fixed threshold be set in `IndexWriterConfig`. Also, there would be many more permutations on whether a particular (type?) of CFS threshold is chosen (ratio based or fixed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
