easyice commented on PR #15045: URL: https://github.com/apache/lucene/pull/15045#issuecomment-3178193246
Thanks for the review Adrien, sorry for not making it clear, this change also use `instanceof FixedBits` to enable the optimization, it will call `fixedBits.bitSet` to get the `FixedBitSet` instance, but just placed the new method `cardinality(Bits, int, int)` in class `FixedBitSet`, so it is also compatible with #14996 in my understand? I had considered another approach: placing the new `cardinality` method in `Bits`, similar to `applyMask`, but it seems that only a util method is needed here, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
