bharath-techie commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2265722765
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java:
##########
@@ -149,9 +150,9 @@ public Lucene101PostingsReader(SegmentReadState state)
throws IOException {
IndexFileNames.segmentFileName(
state.segmentInfo.name, state.segmentSuffix,
Lucene101PostingsFormat.DOC_EXTENSION);
try {
- // Postings have a forward-only access pattern, so pass
ReadAdvice.NORMAL to perform
- // readahead.
- docIn = state.directory.openInput(docName,
state.context.withReadAdvice(ReadAdvice.NORMAL));
+ docIn =
+ state.directory.openInput(
+ docName, state.context.withHints(FileTypeHint.DATA,
FileDataHint.POSTINGS));
Review Comment:
Hi @thecoop @jpountz ,
> This doesn't set a DataAccessHint as it's not RANDOM or SEQUENTIAL, just
NORMAL.
https://github.com/apache/lucene/pull/14635 - with this PR - we have removed
the change in MMAPDirectory to apply read advice as normal. So if no data
access hint is provided, it falls back to default read advice which is random.
So read advice has changed from default to random ? Can you please confirm if
I'm missing something and if not, then should we revert back the read advice to
normal ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
