thecoop commented on code in PR #14863:
URL: https://github.com/apache/lucene/pull/14863#discussion_r2250656468


##########
lucene/core/src/java24/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##########
@@ -563,8 +633,42 @@ private int dotProductBody256Int4Packed(byte[] unpacked, 
byte[] packed, int limi
     return sum;
   }
 
+  private static int dotProductBody256Int4PackedPacked(

Review Comment:
   This looks pretty similar between the multiple implementations. Can the 
vector sizes be arguments to a single method, so the implementation is common 
to all vector sizes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to