jpountz commented on code in PR #14996:
URL: https://github.com/apache/lucene/pull/14996#discussion_r2243068238
##########
lucene/core/src/java/org/apache/lucene/index/SoftDeletesDirectoryReaderWrapper.java:
##########
@@ -188,11 +189,11 @@ private static boolean assertDocCounts(
static final class SoftDeletesFilterLeafReader extends FilterLeafReader {
private final LeafReader reader;
- private final FixedBitSet bits;
+ private final Bits bits;
private final int numDocs;
private final CacheHelper readerCacheHelper;
- private SoftDeletesFilterLeafReader(LeafReader reader, FixedBitSet bits,
int numDocs) {
+ private SoftDeletesFilterLeafReader(LeafReader reader, Bits bits, int
numDocs) {
Review Comment:
The `Bits` are indeed always created bia `FixedBitSet#asReadOnlyBits` but I
liked doing it on the call site better than in this constructor. Since it's a
private constructor, it doesn't break users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
