rmuir commented on issue #14999: URL: https://github.com/apache/lucene/issues/14999#issuecomment-3130390214
Thanks, I just have to be cautious as we get a lot of these :) IIRC, the whole reason for this map is for reader safety: without it, old-school MmapDirectory could `SIGSEGV`, so safety was added to, as best effort as possible, deliver `AlreadyClosedException` when e.g. closed readers were used. Maybe in the `main` branch, where it is always a safe `MemorySegmentIndexInput`, the map could be removed, as users should still be safe from SIGSEGV. I wouldn't feel comfortable at all with removing such safety from branch 10.x, since it could lead to SIGSEGV. I'd want to hear thoughts from @uschindler first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
