jainankitk commented on code in PR #14413: URL: https://github.com/apache/lucene/pull/14413#discussion_r2232092955
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryLeafProfilerBreakdown.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.sandbox.search; + +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.Map; +import org.apache.lucene.util.CollectionUtil; + +/** + * A record of timings for the various operations that may happen during query execution. A node's + * time may be composed of several internal attributes (rewriting, weighting, scoring, etc). + */ +public class QueryLeafProfilerBreakdown { + private static final Collection<QueryProfilerTimingType> LEAF_LEVEL_TIMING_TYPE = + Arrays.stream(QueryProfilerTimingType.values()).filter(t -> t.isLeafLevel()).toList(); + + /** The accumulated timings for this query node */ + private final QueryProfilerTimer[] timers; Review Comment: Although minor, but `EnumMap` will initialize the timers for all the possible keys `vals = new Object[keyUniverse.length];`. It seemed bit unnecessary to me, but we can change if using `EnumMap` improves the readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
