iverase commented on code in PR #14974:
URL: https://github.com/apache/lucene/pull/14974#discussion_r2219884527
##########
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##########
@@ -374,6 +389,9 @@ private static void eliminateHole(
Node node = splitPolygon(outerNode, holeNode, fromPolygon);
// Filter the split nodes.
filterPoints(node, node.next);
+ return true;
+ } else {
+ return false;
Review Comment:
yes, this means we could not find a polygon point to the left of the
leftmodt point of yjr hole, therefore that point must be outside of the
polygon. I will add a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
