shubhamvishu opened a new pull request, #14963:
URL: https://github.com/apache/lucene/pull/14963

   ### Description
   
   This change avoids creating a HNSW graph if the segment is small (here we 
have taken the thresholdfor number of vectors  as `10000` based on the 
conversation 
[here](https://github.com/apache/lucene/issues/13447#issuecomment-3004565232) 
for now). 
   
   Some of the points I'm not sure how we would want to go about :
   - All the tests passes with the threshold `10000` but changing this to lets 
say `10` a lot of those failed since those tests inherently assumes that the 
graph is created and KNN search happened (do we have some idea of how to bypass 
those in some good clean way?)
   - I think we should we keep this optimization always on (less invasive) but 
for(in this PR) now I allowed an option to enable it on the KNN format
   
    
   **TODOs:**
   - Add tests
   - Benchmarks
   
   <!--
   If this is your first contribution to Lucene, please make sure you have 
reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to