dweiss opened a new pull request, #14944:
URL: https://github.com/apache/lucene/pull/14944

   There are two confusing options that the gradle test task has: failfast and 
ignorefailures. One stops the build as soon as the first test failed 
(failfast), the other causes the test task to not fail the build, even if tests 
failed. I introduced a regression where the second was set to true, causing 
tests to never failed the build.
   
   I don't see the benefit of having these two options. Rather, it should be 
that you fail the build early or you fail the build at the very end of 
processing if any test failed. I may clean this up later - for now, re-enabling 
failures on failed tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to