rmuir commented on code in PR #14942: URL: https://github.com/apache/lucene/pull/14942#discussion_r2203121359
########## lucene/core/src/java24/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java: ########## @@ -50,6 +50,7 @@ * * Setting these properties will make this code run EXTREMELY slow! */ +@SuppressForbidden(reason = "vectors module is allowed here") Review Comment: thanks, now that we're scanning (thank you!), I will see if I can tweak this, to try to use a different set of rules somehow for the java24? I'd like to avoid suppressing entire classes, instead i'd like to disable specific trappy methods such as `VectorOperators.FMA`, and only `@SuppressForbidden` the `fma()` helper method that properly checks the CPU capabilities... The idea would be to just ban `VectorOperators.FMA` with a message that instructs you it might be slow on some hardware, please use the `fma()` helper method instead. Same goes for compress/expand. Hope this makes sense, I'm not trying to police `src/java`, I'm trying to police `src/java24` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
