rmuir opened a new pull request, #14938: URL: https://github.com/apache/lucene/pull/14938
Prevent proliferation of vectors api code outside of PanamaVectorUtilSupport. It is already happening: example is the memory segment abstraction, which I've left as a TODO to fix. Let's keep all vectors code into a single file for easy static analysis: we can add simple rules to prevent performance traps instead of constantly staring at assembly, looking at openjdk sources, debugging 10x slowdowns. But we can't do it, if kernels spread via complex java abstractions, because it makes the analysis too difficult. Closes #14937 This is just the first step. We may have to adopt some different patterns and so on with our vectors code to help prevent the traps. But I think we must use automation and not do it manually on every PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
