kaivalnp opened a new pull request, #14934:
URL: https://github.com/apache/lucene/pull/14934
### Description
Refactor classes of the Faiss-based vector format to simplify backport to
10.x
- Extract minimal functionality required for the format into a new
`FaissLibrary` interface
- Separate all function calls to the native library into a new
`FaissNativeWrapper` (and use `invokeExact` for faster calls!)
- Create a new`FaissLibraryNativeImpl` class implementing `FaissLibrary`
with `FaissNativeWrapper` under the hood
- Dynamically load `FaissLibraryNativeImpl` from `FaissLibrary` at runtime
- This setup encapsulates "unsafeness" into `FaissNativeWrapper` and
`FaissLibraryNativeImpl` (as marked by TODOs in #14907), which can
_independently_ be moved into the `java21/` directory for an easier backport
(see comments in #14843), while the `FaissKnnVectors{Format/Reader/Writer}` can
stay as-is!
- Improve some error handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
