georgereuben commented on PR #14927: URL: https://github.com/apache/lucene/pull/14927#issuecomment-3052761977
> Also - this should be primarily for PR authors who, after they submit the PR, find out something didn't pass the check. So it's a convenience to people who don't have permissions to the main Lucene repository. Is this what the permission check is actually verifying (sorry, it's a bit confusing with those permissions)? Understood, thanks for the insight. I see the issue. Should I go ahead and implement a check where it will allow the PR author along with folks with admin and write access to trigger the format bot? I think this should be fine security wise since the automated PR raised would only suggest edits for the PR raised by the person triggering it and not to the main branch. What would you suggest? Working on the other suggestions meanwhile, I will update here soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
