dweiss commented on code in PR #14924:
URL: https://github.com/apache/lucene/pull/14924#discussion_r2194376944
##########
lucene/analysis/common/src/tools/java/org/apache/lucene/analysis/standard/GenerateJflexTLDMacros.java:
##########
@@ -49,11 +51,23 @@
* ASCII-only TLDs, including punycode forms of internationalized TLDs (output
file cmdline arg #1).
*/
public class GenerateJflexTLDMacros {
+ private static PrintStream syserr = getSysErr();
+ private static PrintStream sysout = getSysOut();
+
+ @SuppressForbidden(reason = "Uses System.err, which is fine here.")
+ private static PrintStream getSysErr() {
+ return System.err;
+ }
+
+ @SuppressForbidden(reason = "Uses System.out, which is fine here.")
+ private static PrintStream getSysOut() {
+ return System.err;
+ }
Review Comment:
I pulled out those sysout uses so that other checks are applied. I wish
SuppressForbidden had some more granularity to it (think of labels on signature
sets or something).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
