msokolov commented on PR #13572: URL: https://github.com/apache/lucene/pull/13572#issuecomment-3048723297
Thanks for bringing this up again! Now that Lucene main branch is requiring JDK24 we should be able to simplify a lot of the java interface (no more need for mrjar, I think?) and we should try to find a way to go forward. The performance improvement is just too good; if we don't include this in Lucene, consumers are all going to build local forks to shoehorn it in. it seems to me the main concerns from a user/consumer perspective are: 1. Building the C code must be optional, so platforms that don't support or need it can skip it. 2. The Java interface needs to gracefully fall back when the native module is not present 3. Instructions for linking to the native module need to be clearly documented From a maintainer's POV I think we basically don't want to maintain a complex system of fallbacks and conditional loading that goes beyond what we already have (SPI, mrjars). Hopefully w/JDK24 this is now possible? As a side note, why are we maintaining lucene/core/src/java24 if JDK24 is now the required version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
