rmuir commented on code in PR #14903:
URL: https://github.com/apache/lucene/pull/14903#discussion_r2188517657
##########
build-tools/build-infra/src/main/groovy/lucene.documentation.render-javadoc.gradle:
##########
@@ -364,13 +364,11 @@ abstract class RenderJavadocTask extends
RenderJavadocTaskBase {
.collect { dir -> project.file("${dir}/overview.html") }
.findAll { overviewFile -> overviewFile.exists() }
- if (!overviewFiles.isEmpty()) {
- assert overviewFiles.size() == 1 : "More than one overview file?: " +
overviewFiles
- opts << [
- '-overview',
- project.file("${overviewFiles.getFirst()}/overview.html")
- ]
- }
+ assert overviewFiles.size() == 1 : "Must be exactly one overview.html
file: " + overviewFiles
Review Comment:
I think I got too greedy here, as this trips in CI, but didn't locally, will
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
