mikemccand commented on PR #14837: URL: https://github.com/apache/lucene/pull/14837#issuecomment-3039516748
> Seems a bit weird to include a merge policy change in a PR that is mostly about changing logging, but OK. I think I would be happier if the PR was entitled "Don't invoke merge-on-commit logic if merge policy returns empty list of merges" and secondarily patched infoStream logging. Oh I can revert that part if you want? And break it into its own PR ... My primary purpose here was to fix confusing issues with the `InfoStream` as I was trying to get segment tracing working, and then when I saw MOC logging a pointless/confusing message (`now run merges during commit:` followed by nothing) I wanted to fix that. But you're right -- it does a lot of addition (pointless) things (besides logging) inside that `if`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
