uschindler commented on PR #14896: URL: https://github.com/apache/lucene/pull/14896#issuecomment-3038426091
Hi, I am out of house this weekend In general code and the usual VectorUtil abstraction looks fine; about the risks: - we should have benchmarks also on AMD ryzen/threadripper CPUs as well as ARM. - we should be careful when to enable the opti based on the various constants set based on hotspot flags enabled (which is a way to detect CPUid flags) - @rmuir should have a look, too. He knows all CPU types and risks better than all of us. 🤪 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
