jpountz commented on PR #14896: URL: https://github.com/apache/lucene/pull/14896#issuecomment-3033677309
Wow, this is a big speedup! I'd like to get opinions on `INT_FOR_DOUBLE_SPECIES` from folks who are familiar with the vector API, maybe @uschindler or @ChrisHegarty. I know we've had to be careful with the vector API at times as playing some tricks may get even slower than scalar code on some hardware. > taskCountPerCat=1 FWIW I like higher values of this parameter better. Otherwise a change may look like it's a speedup when in fact it is overfitted for a particular query, and other similar queries don't get the same speedup. I usually keep it at 5 like nightly benchmarks. Separately I wonder if we should keep accumulating scores in `double`s to contain the accuracy loss. We don't do it 100% consistently (e.g. if you mix SHOULD and MUST clauses, or if you have duplicate clauses that get rewritten as a boosted query) and it complicates optimizations like this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
