msfroh commented on issue #14887: URL: https://github.com/apache/lucene/issues/14887#issuecomment-3025801247
Since this would be a pretty disruptive change to anyone who's directly extending `DocIdSetIterator` anyway, I wonder if we can do something around `sealed` classes to say that only `AbstractDocIdSetIterator` and `FilterDocIdSetIterator` are allowed to directly extend `DocIdSetIterator`. Then we could make `docId()` final in each of those. It doesn't make the call-site monomorphic, but we'd still get bimorphic inlining and we'd avoid the extra `docId` field taking up a few bytes on the filter cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
