pmpailis commented on code in PR #14882:
URL: https://github.com/apache/lucene/pull/14882#discussion_r2176981030


##########
lucene/core/src/test/org/apache/lucene/search/TestKnnFloatVectorQuery.java:
##########
@@ -276,6 +277,40 @@ public void testDocAndScoreQueryBasics() throws 
IOException {
     }
   }
 
+  @Nightly
+  public void testKnnQueryWithFiltering() throws IOException {
+    try (Directory directory = newDirectory()) {
+      final DirectoryReader reader;
+      try (RandomIndexWriter iw = new RandomIndexWriter(random(), directory)) {
+        for (int i = 0; i < 100_000; i++) {
+          Document doc = new Document();
+          doc.add(new StringField("id", "text" + i, Field.Store.NO));
+          doc.add(
+              new KnnFloatVectorField(
+                  "vector", new float[] {i, i * 2}, 
VectorSimilarityFunction.DOT_PRODUCT));
+          if (i % 2 == 0) {

Review Comment:
   Trying adding a reproducible case so that we can enforce `DENSE` for 
`IndexedDISI`. Happy to discuss alternative approaches to ensure this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to