dweiss commented on code in PR #14862: URL: https://github.com/apache/lucene/pull/14862#discussion_r2176611928
########## build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/globals/LuceneBuildGlobalsExtension.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.gradle.plugins.globals; + +/** Global build constants. */ +public abstract class LuceneBuildGlobalsExtension { + public static final String NAME = "buildGlobals"; + + /** Base Lucene version ({@code x.y.z}). */ + public String baseVersion; + + /** Major Lucene version ({@code x} in {@code x.y.z}). */ + public String majorVersion; + + /** {@code true} if this build is a snapshot build. */ + public boolean snapshotBuild; Review Comment: Oh, I understand the motivation and theory. I just don't think it helps. My experience says that moving everything to properties doesn't solve anything - it just moves the lazy evaluation to another place but often you have places which can't or don't accept lazy providers and then you need to access the property explicitly using get anyway. Thanks for explaining though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
