Pulkitg64 commented on code in PR #14792:
URL: https://github.com/apache/lucene/pull/14792#discussion_r2168100586
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene95/OffHeapFloatVectorValues.java:
##########
@@ -270,7 +270,8 @@ public DocIdSetIterator iterator() {
}
}
- private static class EmptyOffHeapVectorValues extends
OffHeapFloatVectorValues {
+ /** Empty vector values when there are no vectors stored. */
Review Comment:
Removed this change, since we will check size==0 instead of making the class
public.
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene95/OffHeapFloatVectorValues.java:
##########
@@ -270,7 +270,8 @@ public DocIdSetIterator iterator() {
}
}
- private static class EmptyOffHeapVectorValues extends
OffHeapFloatVectorValues {
Review Comment:
Removed this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
