rmuir opened a new pull request, #14849: URL: https://github.com/apache/lucene/pull/14849
these two checks are currently implemented with regex rules looking for comments, then calling into rat API to check if it is a license. It means parsing every java file with rat just for this purpose, and the regexes are not perfect. The new rules are very simple but find some inconsistencies that weren't found before: they aren't stricter, the previous code just misses some. We now only call into rat here for xml files, separately we should decide if that is worth it. If not, we can reduce the gradle code further and avoid challenges with Rat API on upgrades. To me, checking this for the 29 XML files is not worth the hassle of installing additional C library / configuring `customLanguages` to check the xml with this tool, I add xml parser in my own personal config but I think its too much of a hassle for anyone else / CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
