rmuir commented on code in PR #14825:
URL: https://github.com/apache/lucene/pull/14825#discussion_r2159848746


##########
.github/actions/eclint/action.yml:
##########
@@ -0,0 +1,33 @@
+name: Install eclint
+description: Installs eclint from cache, or builds it
+
+inputs:
+  eclint-version:
+    required: false
+    description: "eclint version to use"
+    default: "v0.5.1"
+
+runs:
+ using: "composite"
+ steps:
+  - name: Cache eclint binary
+    id: cache-eclint
+    uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+    with:
+      path: ~/.local/bin/eclint
+      key: eclint-${{ inputs.eclint-version }}-${{ runner.os }}-${{ 
runner.arch }}

Review Comment:
   May seem overkill to only save single-digit seconds, but the purpose is to 
avoid the network requests (similar to gradle-wrapper).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to