dweiss commented on code in PR #14820:
URL: https://github.com/apache/lucene/pull/14820#discussion_r2158228546
##########
build-tools/build-infra/src/main/groovy/lucene.regenerate.gradle:
##########
@@ -219,7 +219,8 @@ configure([
// Recompute checksums after the task has completed and write them.
def updatedChecksums = computeChecksummedEntries(sourceTask)
checksumsFile.setText(
- JsonOutput.prettyPrint(JsonOutput.toJson(new TreeMap<String,
String>(updatedChecksums))), "UTF-8")
+ JsonOutput.prettyPrint(JsonOutput.toJson(new TreeMap<String,
+ String>(updatedChecksums))) + '\n', "UTF-8")
Review Comment:
This is mildly surprising. Passes with greclipse and both versions are "ok"
for it but I wonder if conflicts between the rules for different systems
(editorconfig, spotless) won't cause headaches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
