dweiss opened a new pull request, #14804:
URL: https://github.com/apache/lucene/pull/14804
Fixes #14553.
I'm not completely happy with this. For some reason, the custom formatting
step always triggers full spotless run - incremental mode doesn't work.
```
> ./gradlew -p lucene/grouping/ spotlessCheck --info
> ./gradlew -p lucene/grouping/ spotlessCheck --info
...
> Task :lucene:grouping:spotlessJava
Caching disabled for task ':lucene:grouping:spotlessJava' because:
Build cache is disabled
Task ':lucene:grouping:spotlessJava' is not up-to-date because:
Value of input property 'stepsInternalEquality' has changed for task
':lucene:grouping:spotlessJava'
The input changes require a full rebuild for incremental task
':lucene:grouping:spotlessJava'.
Not incremental: removing prior outputs
Resolve mutations for :lucene:grouping:spotlessJavaCheck
(Thread[#9108,Execution worker Thread 4,5,main]) started.
:lucene:grouping:spotlessJavaCheck (Thread[#9108,Execution worker Thread
4,5,main]) started.
```
The detection is also costly (regexp over the entire codebase); this could
be probably simplified to line-by-line scanning and a heuristic to
short-circuit early when import statements are no longer possible...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
