hellosunil commented on issue #14769: URL: https://github.com/apache/lucene/issues/14769#issuecomment-2964700843
> I'm happy to see this API being used as it was only added in the last minor release. The change that you are suggested makes sense to me. I'd like to then use doc IDs as a tie-breaker again after computing the RRF score in case there are ties, but I don't expect you to object to that? Yes, I completely agree. > One thing that is a bit annoying with your suggestion is that it would be hard to apply to hits sorted by field rather than score. See e.g. how `TopDocs#merge` needs to handle this, by taking a `Sort` object when hits are sorted by field. Or maybe we shouldn't care too much and document that this RRF helper should only be used for hits sorted by descending score. Thank you for pointing that out; I hadn't considered this aspect. upon reflection, there might be cases where users want to apply RRF to field-sorted results (e.g., giving more weight to recently added documents or other custom sorting criteria). In such cases, when scores are null (e.g. when doDocScores is set to false by the user in IndexSearcher), we could handle this by simply incrementing ranks based on position(though proper documentation would be essential, of course). What do you think about this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
