thecoop commented on PR #14705: URL: https://github.com/apache/lucene/pull/14705#issuecomment-2944318250
There are some non-trivial subclasses (`TopDocs.MergeSortQueue`, `MultiTermsEnum.TermMergeQueue`, `NearSpansUnordered.SpanTotalLengthEndPositionWindow`), some queues that themselves are subclassed (`FieldValueHitQueue`, `TopOrdAndNumberQueue`), and some part of the public API (`HitQueue`, `FieldValueHitQueue`, `SuggestWordQueue`). This PR handles the trivial cases, I was going to create subsequent PRs to cover the more complex refactorings so they can be considered separately, especially those that change the public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
