stefanvodita commented on code in PR #14697:
URL: https://github.com/apache/lucene/pull/14697#discussion_r2105767826
##########
lucene/CHANGES.txt:
##########
@@ -123,6 +127,10 @@ Bug Fixes
* GITHUB#14161: PointInSetQuery's constructor now throws
IllegalArgumentException
instead of UnsupportedOperationException when values are out of order.
(Shubham Sharma)
+* GITHUB#7865 AbstractRangeQueryNode#toQueryString(EscapeQuerySyntax) now
Review Comment:
I'm conflicted because we're changing behaviour that is public and has been
around a long time, but it's also a bug fix. I think I'd be more comfortable if
we moved these entries under 11.0.0 though.
##########
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/nodes/ValueQueryNode.java:
##########
@@ -16,10 +16,14 @@
*/
package org.apache.lucene.queryparser.flexible.core.nodes;
+import org.apache.lucene.queryparser.flexible.core.parser.EscapeQuerySyntax;
+
/** This interface should be implemented by {@link QueryNode} that holds an
arbitrary value. */
public interface ValueQueryNode<T extends Object> extends QueryNode {
public void setValue(T value);
public T getValue();
+
+ public CharSequence getTermEscaped(EscapeQuerySyntax escaper);
Review Comment:
Could we add a comment explaining what this method should do with an example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
