uschindler commented on PR #14642: URL: https://github.com/apache/lucene/pull/14642#issuecomment-2869223919
I am not really happy with that PR because it adds complexity for nonsense: The improvements are not really there because we move the MethodHandle access checks and cracking to the compiler while with the BSM it happens at linking time. When we create the expression we create and link anyways, so it is not a big difference. One can only say that we don't use a MethodHandle at all if the call is direct, but this is no longer relevant (it was in Java 7 / Java 8). So I'd like to stay on safe side and close this. The PR can be used for others to get further inspiration - as playground. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
