dweiss commented on PR #14563: URL: https://github.com/apache/lucene/pull/14563#issuecomment-2858950615
(Note: Please don't take this personally. I just verbalize my opinion on your PR's example but it's nothing against you.) So, here's the problem that I see with force pushes. Let's say I wanted to take a look at the PR's history (backport or otherwise). If I wanted to see what Adrien reviewed last week, here:  I can no longer see it. The commit a972c58 still exists on github (as a detached commit) - [a972c58](https://github.com/apache/lucene/commit/a972c58e308fabb77669866c3a295e47c8d8a2a4) but if I clone (or pull) a fresh content of your repository, it's not referenced from anywhere and won't be present in my local clone. Github may eventually release it too. Force-pushing is essentially moving a branch/tag (or other label) to a different commit; it is a mechanism of "forgetting" about certain commits - those that are no longer referenced by anything can be garbage collected, eventually (this is more complex than branches and tags, but eventually such commits will get removed). In the context of public discussion, I think this shouldn't be done. The history of a PR and its reviews should be preserved. I personally also don't think you need to credit anybody that much when backporting... Their credit is already mentioned on the original PR and perhaps in the changes.txt file. Finally, thank you for working on this, of course! ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
