jainankitk commented on PR #14622: URL: https://github.com/apache/lucene/pull/14622#issuecomment-2856822872
Then, I realized that while `CELL_OUTSIDE_QUERY` was not possible for `MATCH_ALL`, it is possible for `PointRangeQuery`. Not having that condition, prevents early termination for cases the whole subtree is outside the desired range. After adding the condition, benchmark significantly improved (more than 10x), but still worse than original: ``` Benchmark (bucketWidth) (docCount) (pointEnabled) Mode Cnt Score Error Units HistogramCollectorBenchmark.pointRangeQueryHistogram 5000 500000 true thrpt 3 6076.706 ± 2409.983 ops/s HistogramCollectorBenchmark.pointRangeQueryHistogram 5000 500000 false thrpt 3 1358382.893 ± 1334350.071 ops/s HistogramCollectorBenchmark.pointRangeQueryHistogram 5000 5000000 true thrpt 3 882.275 ± 116.196 ops/s HistogramCollectorBenchmark.pointRangeQueryHistogram 5000 5000000 false thrpt 3 795601.855 ± 674228.821 ops/s HistogramCollectorBenchmark.pointRangeQueryHistogram 25000 500000 true thrpt 3 14128.799 ± 6995.352 ops/s HistogramCollectorBenchmark.pointRangeQueryHistogram 25000 500000 false thrpt 3 1406723.413 ± 618403.154 ops/s HistogramCollectorBenchmark.pointRangeQueryHistogram 25000 5000000 true thrpt 3 3439.462 ± 360.741 ops/s HistogramCollectorBenchmark.pointRangeQueryHistogram 25000 5000000 false thrpt 3 1247846.878 ± 1234125.682 ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org