kaivalnp commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2855355008
Thanks @mikemccand ! > Does this mean CI builds will be able to install Faiss and run the tests here? Yes, we're able to install Faiss from the `pytorch` channel and run tests (here's an [example run](https://github.com/kaivalnp/lucene/actions/runs/14681627295/job/41204980909?pr=4)) -- just one small open question on whether to use `micromamba` (which seems faster and cleaner) or `miniforge` (which is fine too, license-wise) as the Conda distribution -- see [this comment](https://github.com/apache/lucene/pull/14178#issuecomment-2832287372) > What is the new developer experience like (who has not installed Faiss) -- are the tests gracefully ignored? Yes, Faiss tests are ignored if any of the required shared libraries are not present at runtime (either on `-Djava.library.path` or `LD_LIBRARY_PATH`) -- except in the CI test, where we explicity enable Faiss tests using `-Dtests.faiss.run=true` > If conda-forge build for Faiss 1.11.0+ arrives, we can cutover then. Maybe open a follow-on issue for that Makes sense, I'll add a TODO here and open an issue once this is merged.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
