jainankitk commented on PR #14527: URL: https://github.com/apache/lucene/pull/14527#issuecomment-2820142632
> We need to make sure that there are no significant performance or concurrency bugs introduced with this. Could you test with https://github.com/mikemccand/luceneutil to verify recall, multi-threaded merge, etc. ? +1 on the performance. Using `IntArrayList` instead of int[] can impact the performance due to the overhead of copying while growing the array. Although, I am not completely sure if this change should cause any concurrency bugs compared to original. @benwtrent - Do you have anything specific in mind, that I might be missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
