gf2121 commented on PR #14475: URL: https://github.com/apache/lucene/pull/14475#issuecomment-2815249828
It occurs to me that logic like: ``` DocValuesIterator iter = DocValuesIterator.of(1, 2, 4); boolean exist = iter.advanceExact(3); assert exist == false; iter.intoBitSet(upto, bitset, offset); ``` now seems problematic, because the default implementation of `intoBitSet` starts with a docID() that doesn't actually exist? +1 again to change the contract, let's make `docID()` always return a existed doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
