rmuir commented on issue #14483: URL: https://github.com/apache/lucene/issues/14483#issuecomment-2803747512
The problematic helper code (used by both test methods implicated here) is `stressUpdateSameDocumentWithMergeOnX`. This one looks tricky as it indexes a non-obvious amount of docs and instead waits for special conditions to happen. The usual helper method I had in mind (`TestUtil.reduceOpenFiles()`) isn't so helpful for this particular test because we actually care about merge policy settings. The helper can only be used by tests that don't care deeply about these. It is also a problem the entire test class starts like this: ```java @HandleLimitFS.MaxOpenHandles(limit = HandleLimitFS.MaxOpenHandles.MAX_OPEN_FILES * 2) ``` That defeats the entire purpose of the limit: which is to make these failures reproducible instead of only failing on certain OS/VM/configuration/circuitry. It hides the problem locally. So it must be removed as part of the fix. I don't have a fix quite yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
