viliam-durina commented on issue #14334: URL: https://github.com/apache/lucene/issues/14334#issuecomment-2772476115
>There has to be a certain trust in what the operating system provides and its consistency guarantees Sure, but the OS doesn't guarantee anything, if you don't fsync. I'd say you can have a degree of optimism that the probability of an undetected corruption is _low enough_. But I think I've made my case that it's possible to fix this with no performance hit and acceptable complexity. I went through the code, I think it's pretty straightforward in the places I saw. I can try, maybe just tell me if you'd accept a solution along the lines [described here](https://github.com/apache/lucene/issues/14334#issuecomment-2771963385), so that I don't waste time. Let's return to the bigger issue: fsyncing non-temporary files before closing them, which probably was the root cause of #10906. Can we agree that this is an issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
