thecoop commented on code in PR #14419:
URL: https://github.com/apache/lucene/pull/14419#discussion_r2018614545
##########
lucene/core/src/test/org/apache/lucene/internal/vectorization/TestVectorUtilSupport.java:
##########
@@ -210,9 +210,13 @@ public void testMinMaxScalarQuantize() {
}
private void
assertFloatReturningProviders(ToDoubleFunction<VectorUtilSupport> func) {
- assertThat(
- func.applyAsDouble(PANAMA_PROVIDER.getVectorUtilSupport()),
- closeTo(func.applyAsDouble(LUCENE_PROVIDER.getVectorUtilSupport()),
delta));
+ double luceneValue =
func.applyAsDouble(LUCENE_PROVIDER.getVectorUtilSupport());
Review Comment:
I think `closeTo` gives better error messages (specifying the delta, as in
the error message, rather than just giving the two values and letting you work
it out). It's also a clearer assert specification in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
