jpountz commented on PR #14409: URL: https://github.com/apache/lucene/pull/14409#issuecomment-2758339188
I don't think that the timout support that you are introducing buys anything compared with the existing timeout support via `IndexSearcher#setTimeout` and `TimeLimitingBulkScorer`. To me the interesting part is the ability to estimate the maximum possible score for various ranges of the doc ID space (there is an assumption that something like recursive graph bisection is enabled at index time) so that they can be searched first in order to help dynamic pruning, but it looks like this bit is left to the user in your PR. It would be interesting to look into doing this in Lucene by looking at impact blocks (`Scorer#advanceShallow`, `Scorer#getMaxScore`) for the various disjunctive clauses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
